mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 65126: Added a resource provider test case.
Date Tue, 16 Jan 2018 11:05:34 GMT


> On Jan. 15, 2018, 10:57 a.m., Benjamin Bannier wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 1345 (patched)
> > <https://reviews.apache.org/r/65126/diff/1/?file=1939684#file1939684line1345>
> >
> >     This does look more like an agent integration test to me; maybe move it to `slave_tests.cpp`
instead?

It's both, master and agent integration tests, though the focus is on the master. Moved it
to `master_test.cpp` and renamed it to make clear that it's about `UpdateSlaveMessage`.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195412
-----------------------------------------------------------


On Jan. 16, 2018, 12:04 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65126/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2018, 12:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
>     https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a resource provider test case.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65126/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message