mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65171: Reduced copying of Response by adding extra override Headers.
Date Mon, 15 Jan 2018 21:06:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65171/#review195437
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/src/encoder.hpp
Line 171 (original), 175-180 (patched)
<https://reviews.apache.org/r/65171/#comment274615>

    Copying all the headers is pretty expensive too :(


- Benjamin Mahler


On Jan. 15, 2018, 8:46 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65171/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2018, 8:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reduced copying of Response by adding extra override Headers.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/encoder.hpp 70b5ec479e90c0eb6ac729b465739b581729a956 
>   3rdparty/libprocess/src/http.cpp cc41fa6f671cf029a46722299eded1a27da210d3 
> 
> 
> Diff: https://reviews.apache.org/r/65171/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message