mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65045: Tested correct operation handling during master failover.
Date Mon, 15 Jan 2018 10:58:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195416
-----------------------------------------------------------




src/tests/master_tests.cpp
Lines 8617 (patched)
<https://reviews.apache.org/r/65045/#comment274589>

    `s/auto/master::Flags`



src/tests/master_tests.cpp
Lines 8695 (patched)
<https://reviews.apache.org/r/65045/#comment274590>

    Trim spaces before EOL comment.



src/tests/master_tests.cpp
Lines 8702 (patched)
<https://reviews.apache.org/r/65045/#comment274604>

    Can we add a check that we are offered all resources here?



src/tests/master_tests.cpp
Lines 8750 (patched)
<https://reviews.apache.org/r/65045/#comment274595>

    Let's capture the deserialized response in a variable and check that it is valid so we
don't abort,
    
        Try<v1::master::Response> response_ =
          deserialize<v1::master::Response>(ContentType::PROTOBUF, response->body);
          
        ASSERT_SOME(response_);
        v1::master::Response::GetAgents agents = response_->get_agents();



src/tests/master_tests.cpp
Lines 8766 (patched)
<https://reviews.apache.org/r/65045/#comment274597>

    Since this is related to the agent reregistration, could we move this below the comment
below just before we start the new master?



src/tests/master_tests.cpp
Lines 8780 (patched)
<https://reviews.apache.org/r/65045/#comment274598>

    Trim spaces before EOL comment.



src/tests/master_tests.cpp
Lines 8787 (patched)
<https://reviews.apache.org/r/65045/#comment274606>

    Can we add a check that we are offered all resources here?



src/tests/master_tests.cpp
Lines 8817-8819 (patched)
<https://reviews.apache.org/r/65045/#comment274601>

    Let's check the deserialization result, see above.



src/tests/master_tests.cpp
Lines 8827 (patched)
<https://reviews.apache.org/r/65045/#comment274603>

    Can we add an additional check that we are offered all resources after the operation went
through?


- Benjamin Bannier


On Jan. 9, 2018, 2:28 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2018, 2:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
>     https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message