mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.
Date Sat, 13 Jan 2018 07:30:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/#review195389
-----------------------------------------------------------



PASS: Mesos patch 65147 was successfully built and tested.

Reviews applied: `['65144', '65145', '65147']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147

- Mesos Reviewbot Windows


On Jan. 12, 2018, 10:31 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65147/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 10:31 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8443
>     https://issues.apache.org/jira/browse/MESOS-8443
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `docker` isn't always installed in `os::host_default_path()` on Windows,
> so the docker executor cannot find it. Now, before launching the
> executor, the mesos agent finds `docker`'s parent directory and appends
> that to `PATH`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 
> 
> 
> Diff: https://reviews.apache.org/r/65147/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on Windows 10, all passed.
> 
> Integration tested (courtsey of Akash) that Docker containers can be launched without
manually fixing the path.
> 
> `make check` on CentOS 7, all passed.
> 
> NOTE: This is Windows-only, and replaces [#64570](https://reviews.apache.org/r/64570/).
Joseph and I worked out this approach to prevent a regression for Mesos customers moving from
`1.4` to `1.5`; see MESOS-8443 for details.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message