mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65149: MesosTidy: Enabled `mesos-this-capture`.
Date Sat, 13 Jan 2018 07:27:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65149/#review195388
-----------------------------------------------------------


Fix it, then Ship it!





support/clang-tidy
Line 26 (original), 26 (patched)
<https://reviews.apache.org/r/65149/#comment274556>

    We can just remove this line as `mesos-this-capture` is included in `mesos-*`.


- Benjamin Bannier


On Jan. 13, 2018, 6:32 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65149/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2018, 6:32 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MesosTidy: Enabled `mesos-this-capture`.
> 
> 
> Diffs
> -----
> 
>   support/clang-tidy d68ddab6c796f1f583fb72ec06d6a91d845d1da9 
> 
> 
> Diff: https://reviews.apache.org/r/65149/diff/1/
> 
> 
> Testing
> -------
> 
> Ran `support/mesos-tidy.sh` and confirmed that the false positives have disappeared.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message