mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.
Date Sat, 13 Jan 2018 06:30:57 GMT


> On Jan. 12, 2018, 6:51 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some Mesos tests failed.
> > 
> > Reviews applied: `['65144', '65145', '65146', '65147']`
> > 
> > Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147
> > 
> > Relevant logs:
> > 
> > - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147/logs/mesos-tests-stdout.log):
> > 
> > ```
> > [ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
> > [       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 ms)
> > [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (68 ms total)
> > 
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest
> > [ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
> > [       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2481 ms)
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest (2505 ms total)
> > 
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest
> > [ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
> > [       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2379 ms)
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest (2402 ms total)
> > 
> > [----------] Global test environment tear-down
> > [==========] 856 tests from 86 test cases ran. (309199 ms total)
> > [  PASSED  ] 849 tests.
> > [  FAILED  ] 7 tests, listed below:
> > [  FAILED  ] HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPWithContainerImage
> > [  FAILED  ] HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPSWithContainerImage
> > [  FAILED  ] HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaTCPWithContainerImage
> > [  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
> > [  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
> > [  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
> > [  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
> > 
> >  7 FAILED TESTS
> >   YOU HAVE 214 DISABLED TESTS
> > 
> > ```
> > 
> > - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147/logs/mesos-tests-stderr.log):
> > 
> > ```
> > I0113 02:51:12.640440 10348 slave.cpp:3388] Shutting down frameI0113 02:51:11.954365
 5936 exec.cpp:162] Version: 1.6.0
> > I0113 02:51:11.985371 15076 exec.cpp:236] Executor registered on agent e7aa8781-54a9-412d-bea4-00dcd5b00201-S0
> > I0113 02:51:11.988370 13828 executor.cpp:171] Received SUBSCRIBED event
> > I0113 02:51:11.993367 13828 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
> > I0113 02:51:11.993367 13828 executor.cpp:171] Received LAUNCH event
> > I0113 02:51:11.997367 13828 executor.cpp:638] Starting task ca210858-1bd1-442c-9903-2675f2028a00
> > I0113 02:51:12.076376 13828 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
> > I0113 02:51:12.616439 13828 executor.cpp:651] Forked command at 10492
> > I0113 02:51:12.642441 10516 exec.cpp:445] Executor asked to shutdown
> > I0113 02:51:12.643440 13828 executor.cpp:171] Received SHUTDOWN event
> > I0113 02:51:12.643440 13828 executor.cpp:748] Shutting down
> > I0113 02:51:12.643440 13828 executor.cpp:863] Sending SIGTERM to process tree at
pid work e7aa8781-54a9-412d-bea4-00dcd5b00201-0000
> > I0113 02:51:12.640440  1248 master.cpp:10161] Updating the state of task ca210858-1bd1-442c-9903-2675f2028a00
of framework e7aa8781-54a9-412d-bea4-00dcd5b00201-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
> > I0113 02:51:12.641441 10348 slave.cpp:6066] Shutting down executor 'ca210858-1bd1-442c-9903-2675f2028a00'
of framework e7aa8781-54a9-412d-bea4-00dcd5b00201-0000 at executor(1)@10.3.1.11:50065
> > I0113 02:51:12.642441 10348 slave.cpp:931] Agent terminating
> > W0113 02:51:12.642441 10348 slave.cpp:3384] Ignoring shutdown framework e7aa8781-54a9-412d-bea4-00dcd5b00201-0000
because it is terminating
> > I0113 02:51:12.643440  1248 master.cpp:10265] Removing task ca210858-1bd1-442c-9903-2675f2028a00
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework e7aa8781-54a9-412d-bea4-00dcd5b00201-0000 on agent e7aa8781-54a9-412d-bea4-00dcd5b00201-S0
at slave(329)@10.3.1.11:50044 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0113 02:51:12.645442 10348 containerizer.cpp:2352] Destroying container 5e1f835c-6470-42e4-98cb-6a4beaf21b3b
in RUNNING state
> > I0113 02:51:12.645442 10348 containerizer.cpp:2966] Transitioning the state of container
5e1f835c-6470-42e4-98cb-6a4beaf21b3b from RUNNING to DESTROYING
> > I0113 02:51:12.646443  1248 master.cpp:1306] Agent e7aa8781-54a9-412d-bea4-00dcd5b00201-S0
at slave(329)@10.3.1.11:50044 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
> > I0113 02:51:12.646443  1248 master.cpp:3287] Disconnecting agent e7aa8781-54a9-412d-bea4-00dcd5b00201-S0
at slave(329)@10.3.1.11:50044 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0113 02:51:12.646443  1248 master.cpp:3306] Deactivating agent e7aa8781-54a9-412d-bea4-00dcd5b00201-S0
at slave(329)@10.3.1.11:50044 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0113 02:51:12.647442  8488 hierarchical.cpp:344] Removed framework e7aa8781-54a9-412d-bea4-00dcd5b00201-0000
> > I0113 02:51:12.647442 10348 launcher.cpp:156] Asked to destroy container 5e1f835c-6470-42e4-98cb-6a4beaf21b3b
> > I0113 02:51:12.647442  8488 hierarchical.cpp:766] Agent e7aa8781-54a9-412d-bea4-00dcd5b00201-S0
deactivated
> > I0113 02:51:12.662467 15332 containerizer.cpp:2805] Container 5e1f835c-6470-42e4-98cb-6a4beaf21b3b
has exited
> > I0113 02:51:12.691478 12044 master.cpp:1148] Master terminating
> > I0113 02:51:12.693472  5932 hierarchical.cpp:609] Removed agent e7aa8781-54a9-412d-bea4-00dcd5b00201-S0
> > I0113 02:51:13.072494  9176 process.cpp:888] Failed to accept socket: future discarded
> > ```

Hm, they passed locally. /shrug. I'll just remove that patch from the chain for now, it's
not necessary.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/#review195383
-----------------------------------------------------------


On Jan. 12, 2018, 5:35 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65147/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 5:35 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8443
>     https://issues.apache.org/jira/browse/MESOS-8443
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `docker` isn't always installed in `os::host_default_path()` on Windows,
> so the docker executor cannot find it. Now, before launching the
> executor, the mesos agent finds `docker`'s parent directory and appends
> that to `PATH`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 
> 
> 
> Diff: https://reviews.apache.org/r/65147/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on Windows 10, all passed.
> 
> Integration tested (courtsey of Akash) that Docker containers can be launched without
manually fixing the path.
> 
> `make check` on CentOS 7, all passed.
> 
> NOTE: This is Windows-only, and replaces [#64570](https://reviews.apache.org/r/64570/).
Joseph and I worked out this approach to prevent a regression for Mesos customers moving from
`1.4` to `1.5`; see MESOS-8443 for details.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message