mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61158: Introduced http::Server in process.cpp.
Date Sat, 13 Jan 2018 02:21:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61158/#review195375
-----------------------------------------------------------


Ship it!




Can we clarify why we ifdef guarded it? Specifically only to ensure that there's no performance
regression before removing the HttpProxy, right?


3rdparty/libprocess/src/process.cpp
Lines 1239 (patched)
<https://reviews.apache.org/r/61158/#comment274551>

    s/incomping/incoming/



3rdparty/libprocess/src/process.cpp
Lines 1244 (patched)
<https://reviews.apache.org/r/61158/#comment274552>

    CHECK_EQ?



3rdparty/libprocess/src/process.cpp
Lines 1262 (patched)
<https://reviews.apache.org/r/61158/#comment274553>

    http server?


- Benjamin Mahler


On Nov. 26, 2017, 10:28 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61158/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2017, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Avinash sridharan, and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using http::Server can be compile time configured via USE_HTTP_SERVER.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf 
> 
> 
> Diff: https://reviews.apache.org/r/61158/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message