mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65056: Added missing fields to the GET_MASTER operator API call.
Date Sat, 13 Jan 2018 01:57:42 GMT


> On Jan. 13, 2018, 1:14 a.m., Vinod Kone wrote:
> > Can you update the `GetMaster` test in api_tests.cpp?

Yep, shoulda done this in the first place - thx! Test updated.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65056/#review195370
-----------------------------------------------------------


On Jan. 13, 2018, 1:56 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65056/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2018, 1:56 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gaston Kleiman, and Vinod Kone.
> 
> 
> Bugs: MESOS-8078
>     https://issues.apache.org/jira/browse/MESOS-8078
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Several fields were present in the old master '/state' endpoint,
> which are now not accessible via the V1 operator API. This patch
> adds these fields to the response for the GET_MASTER call.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto f4506fe82ee7c1db77cfb7e94933d5a7f4b024df 
>   include/mesos/v1/master/master.proto 5cb64df12459b1529306cd33691c003172e4b3ec 
>   src/master/http.cpp 0c2cd554124ee400c05f3256af36974a62e2303c 
>   src/tests/api_tests.cpp 28d46436b9c2fe85bde5bc8def7a840b72d29de3 
> 
> 
> Diff: https://reviews.apache.org/r/65056/diff/4/
> 
> 
> Testing
> -------
> 
> tested manually using curl
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message