mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65137: Added some deduplication logic to `Master::updateOperation`.
Date Sat, 13 Jan 2018 01:50:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65137/#review195376
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['65093', '65095', '65096', '65072', '65137']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65137

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65137/logs/mesos-tests-stdout.log):

```
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.UnsupportedContentMediaType/0
(4 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.UnsupportedContentMediaType/1
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.UnsupportedContentMediaType/1
(4 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.UpdateState/0
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.UpdateState/0 (10 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.UpdateState/1
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.UpdateState/1 (14 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.UpdateOperationStatus/0
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.UpdateOperationStatus/0 (8 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.UpdateOperationStatus/1
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.UpdateOperationStatus/1 (11 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesSuccess/0
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesSuccess/0 (16
ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesSuccess/1
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesSuccess/1 (15
ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesFailure/0
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesFailure/0 (11
ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesFailure/1
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesFailure/1 (16
ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesDisconnected/0
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesDisconnected/0
(9 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesDisconnected/1
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.PublishResourcesDisconnected/1
(13 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.AgentEndpoint/0
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.AgentEndpoint/0 (152 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.AgentEndpoint/1
[       OK ] ContentType/ResourceProviderManagerHttpApiTest.AgentEndpoint/1 (153 ms)
[ RUN      ] ContentType/ResourceProviderManagerHttpApiTest.ConvertResources/0
D:\DCOS\mesos\mesos\src\tests\resource_provider_manager_tests.cpp(1041): error: Failed to
wait 15secs for offers2
```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65137/logs/mesos-tests-stderr.log):

```
    @   00007FF649D1CC31  google::LogMessageFatal::~LogMessageFatal
    @   00007FF6474E829B  mesos::internal::master::Master::updateOperationStatus
    @   00007FF6476501DF  ProtobufProcess<mesos::internal::master::Master>::_handlerM<mesos::internal::UpdateOperationStatusMessage>
    @   00007FF6475DAD59  __cdecl*& __ptr64)(mesos::internal::master::Master * __ptr64,void
(__cdecl mesos::internal::master::Master::*)(mesos::internal::UpdateOperationStatusMessage
const & __ptr64) __ptr64,process::UPID const & __ptr64,std::basic_string<char,std::char_traits<ch
    @   00007FF6476A9830  __cdecl*& __ptr64)(mesos::internal::master::Master * __ptr64,void
(__cdecl mesos::internal::master::Master::*)(mesos::internal::UpdateOperationStatusMessage
const & __ptr64) __ptr64,process::UPID const & __ptr64,std::basic_string<char,std::char_traits<ch
    @   00007FF6475DAC80  __cdecl*& __ptr64)(mesos::internal::master::Master * __ptr64,void
(__cdecl mesos::internal::master::Master::*)(mesos::internal::UpdateOperationStatusMessage
const & __ptr64) __ptr64,process::UPID const & __ptr64,std::basic_string<char,std::char_traits<ch
    @   00007FF6475F3F03  __cdecl*)(mesos::internal::master::Master * __ptr64,void (__cdecl
mesos::internal::master::Master::*)(mesos::internal::UpdateOperationStatusMessage const &
__ptr64) __ptr64,process::UPID const & __ptr64,std::basic_string<char,std::char_traits<char>,std::
    @   00007FF6475B721B  __cdecl*)(mesos::internal::master::Master * __ptr64,void (__cdecl
mesos::internal::master::Master::*)(mesos::internal::UpdateOperationStatusMessage const &
__ptr64) __ptr64,process::UPID const & __ptr64,std::basic_string<char,std::char_traits<char>,std::
    @   00007FF6475E3928  __cdecl*)(mesos::internal::master::Master * __ptr64,void (__cdecl
mesos::internal::master::Master::*)(mesos::internal::UpdateOperationStatusMessage const &
__ptr64) __ptr64,process::UPID const & __ptr64,std::basic_string<char,std::char_traits<char>,std::
    @   00007FF6476AE028  __cdecl*)(mesos::internal::master::Master * __ptr64,void (__cdecl
mesos::internal::master::Master::*)(mesos::internal::UpdateOperationStatusMessage const &
__ptr64) __ptr64,process::UPID const & __ptr64,std::basic_string<char,std::char_traits<char>,std::
    @   00007FF6475E3898  __cdecl*)(mesos::internal::master::Master * __ptr64,void (__cdecl
mesos::internal::master::Master::*)(mesos::internal::UpdateOperationStatusMessage const &
__ptr64) __ptr64,process::UPID const & __ptr64,std::basic_string<char,std::char_traits<char>,std::
    @   00007FF6477D43DA  __cdecl*)(mesos::internal::master::Master * __ptr64,void (__cdecl
mesos::internal::master::Master::*)(mesos::internal::UpdateOperationStatusMessage const &
__ptr64) __ptr64,process::UPID const & __ptr64,std::basic_string<char,std::char_traits<char>,std::
    @   00007FF645F19C9B   ?? 
    @   00007FF64785D072  ProtobufProcess<mesos::internal::master::Master>::consume
    @   00007FF6474FE5BC  mesos::internal::master::Master::_consume
    @   00007FF6474FC47D  mesos::internal::master::Master::consume
    @   00007FF64785D47A  process::MessageEvent::consume
    @   00007FF645C39497  process::ProcessBase::serve
    @   00007FF6496D87E0  process::ProcessManager::resume
    @   00007FF6497E1FE1   ?? 
    @   00007FF649720BE0  std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7>
>
    @   00007FF649776580  std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
    @   00007FF64972FADC  std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
>,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
> > > >::_Execute<0>
    @   00007FF64982DB7A  std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
>,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
> > > >::_Run
    @   00007FF64981A608  std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
>,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
> > > >::_Go
    @   00007FF6498022ED  std::_Pad::_Call_func
    @   00007FF64A9CD038  invoke_thread_procedure
    @   00007FF64A9CCAE1  __cdecl*)(void * __ptr64)
    @   00007FFD31661FE4  BaseThreadInitThunk
```

- Mesos Reviewbot Windows


On Jan. 12, 2018, 4:28 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65137/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 4:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds some logic to deduplicate the status updates that are
> added to `Operation::statuses`. The logic is consistent with the
> handling of task status updates, but we should revisit it in MESOS-8441.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp c96cd7090875fbf1b11b1708390e88182c77655b 
> 
> 
> Diff: https://reviews.apache.org/r/65137/diff/3/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh` on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message