mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Review Request 65147: Windows: Fixed docker executor `PATH` variable.
Date Sat, 13 Jan 2018 01:35:35 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.

Bugs: MESOS-8443

Repository: mesos


`docker` isn't always installed in `os::host_default_path()` on Windows,
so the docker executor cannot find it. Now, before launching the
executor, the mesos agent finds `docker`'s parent directory and appends
that to `PATH`.


  src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 



Tested on Windows 10, all passed.

Integration tested (courtsey of Akash) that Docker containers can be launched without manually
fixing the path.

`make check` on CentOS 7 (results pending, prior build with `os::which` changes passed tests)


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message