mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 65141: Fixed the default executor flaky testes in tests/cluster.cpp.
Date Sat, 13 Jan 2018 00:37:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65141/#review195368
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Jan. 13, 2018, 12:15 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65141/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2018, 12:15 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, Benjamin Mahler, Jie Yu,
and Vinod Kone.
> 
> 
> Bugs: MESOS-7506
>     https://issues.apache.org/jira/browse/MESOS-7506
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes some flaky tests listed below:
> 1. DefaultExecutorTest.KillTask/0
> 2. DefaultExecutorTest.TaskWithFileURI/0
> 3. DefaultExecutorTest.ResourceLimitation/0
> 4. DefaultExecutorTest.KillMultipleTasks/0
> 
> The root cause is that either docker containerizer or mesos
> containerizer have wait() and destroy() rely on the same
> future `ContainerTermination` which means these two methods
> become ready simultaneously, but this is not true for the
> composing containerizer because wait() may finish before
> destroy in which case the `containers_` hasshmap is not
> cleaned up yet in destroy()'s `.onAny` callback.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.cpp 066dd31a7b5b49823ca642dfcc930f00e920feb3 
> 
> 
> Diff: https://reviews.apache.org/r/65141/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message