mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65095: Made it possible to update an operation without mutating resources.
Date Fri, 12 Jan 2018 20:56:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65095/#review195346
-----------------------------------------------------------


Ship it!





src/master/master.cpp
Line 10318 (original), 10319 (patched)
<https://reviews.apache.org/r/65095/#comment274512>

    As we discussed in chat, while this isn't a huge deal at present (since updates are being
acknowledged immediately by the master), we'll want to change this anyway once we have the
framework API in place for operation feedback. If this helper is going to be called upon every
receipt of an UpdateOperationStatusMessage, then we won't want to push the statuses from update
retries onto the master's internal state. Once we're relying on frameworks to acknowledge,
this could be an issue.
    
    Gaston and I will follow up with a patch to implement some simple de-duplication for now,
and we can revisit correct de-duplication semantics later on, when the operation update workflow
becomes more complex.


- Greg Mann


On Jan. 12, 2018, 10:53 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65095/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 10:53 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8422
>     https://issues.apache.org/jira/browse/MESOS-8422
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In certain situations it can make sense to update the state of an
> operation without also wanting to update resources. In this patch we
> modify the master's `updateOperation` function to take an additional
> parameter signifying whether resources should be updated, or whether
> we only care about updating the operation and tracking of used
> resources.
> 
> We will use this functionality in a subsequent patch to perform more
> contained updates to agent state when processing `UpdateSlaveMessages`
> which contain both resources and operations (and where any terminal
> operations were already applied to the agent's resources).
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp cdfd06ceb2a8eafa60d0af382b628b165e4ddcb5 
>   src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab 
> 
> 
> Diff: https://reviews.apache.org/r/65095/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message