mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.
Date Fri, 12 Jan 2018 19:24:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64940/
-----------------------------------------------------------

(Updated Jan. 12, 2018, 7:24 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Jie Yu, Vinod Kone, and Jiang Yan
Xu.


Changes
-------

Addressed nits.


Bugs: MESOS-8337
    https://issues.apache.org/jira/browse/MESOS-8337


Repository: mesos


Description
-------

If an agent is lost, we try to remove all the tasks that might have
been lost. If a task is already terminal but has unacknowleged status
updates, it is expected that we track it in the unreachable tasks list
so we should remove the CHECK that prevents this. This also backs out
changes to how unreachable tasks are presented in the HTTP endpoints to
restore compatibility with previous Mesos releases.


Diffs (updated)
-----

  src/master/http.cpp bc29fafb1f4b515aec3b77850f960c88a65c8362 
  src/master/master.hpp f915c6f611eaffd5c2cb6cba6c43def679e8f92d 
  src/master/master.cpp c96cd7090875fbf1b11b1708390e88182c77655b 
  src/tests/mesos.hpp 93913f2e01898c73e09de58a975aa467e714d882 
  src/tests/partition_tests.cpp 3813139f576ea01db0197f0fe8a73597db1bb69a 


Diff: https://reviews.apache.org/r/64940/diff/7/

Changes: https://reviews.apache.org/r/64940/diff/6-7/


Testing
-------

make check (Fedora 27)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message