mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call.
Date Fri, 12 Jan 2018 15:44:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65122/#review195327
-----------------------------------------------------------



PASS: Mesos patch 65122 was successfully built and tested.

Reviews applied: `['65122']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65122

- Mesos Reviewbot Windows


On Jan. 12, 2018, 12:23 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65122/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 12:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Kevin Klues.
> 
> 
> Bugs: MESOS-7742
>     https://issues.apache.org/jira/browse/MESOS-7742
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, io switchboard terminated itself after io redirect is
> finished and before http response was sent to the agent for
> `ATTACH_CONTAINER_INPUT` request. This patch adds a check that an
> input connection exists in io redirect completion callback to postpone
> termination until `ATTACH_CONTAINER_INPUT` is completely processed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 89dd4988c7132d3c7aeacecad7a76961b0ec5a2c

> 
> 
> Diff: https://reviews.apache.org/r/65122/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message