mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 65074: Fixed comparison logic for additive reconfiguration policy.
Date Fri, 12 Jan 2018 15:40:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65074/
-----------------------------------------------------------

(Updated Jan. 12, 2018, 3:40 p.m.)


Review request for mesos, James Peach and Vinod Kone.


Bugs: MESOS-8410
    https://issues.apache.org/jira/browse/MESOS-8410


Repository: mesos


Description (updated)
-------

The case where multiple resources have the same name
was not handled correctly, and could result in false
negatives.


Diffs (updated)
-----

  include/mesos/resources.hpp 69bf823f800ac8bfc2bc211895b0967f573009b5 
  src/common/resources.cpp 1291208b9f2a7c373ff7ec941d3e4310fec92207 
  src/slave/compatibility.hpp 78b421a01abe5d2178c93832577577a7ba282b38 
  src/slave/compatibility.cpp 4ead4a5b655f6f3d7812aa52d656830d7cff4598 
  src/tests/slave_compatibility_tests.cpp ab5ed29f43c593dbd7d90c235aa304b581d932a2 


Diff: https://reviews.apache.org/r/65074/diff/2/

Changes: https://reviews.apache.org/r/65074/diff/1-2/


Testing
-------

* Several new unit tests added in the review
* `make check`


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message