mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 63859: Windows: Fixed mock signal values in stout.
Date Fri, 12 Jan 2018 14:33:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63859/
-----------------------------------------------------------

(Updated Jan. 12, 2018, 2:33 p.m.)


Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Changes
-------

Removed SIGSTOP and SIGCONT


Bugs: MESOS-7342
    https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description (updated)
-------

Removed `SIGSTOP` and `SIGCONT` on Windows, since they are meaningless,
and never unused. Also, fixed the WEXITSTATUS macro to cast the exit
code instead of bit-masking it, since Windows exit codes are 32 bit
unsigned ints.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/kill.hpp b2a36b5c07df6642bb9b08b61ab3b678bf8a6b36

  3rdparty/stout/include/stout/windows.hpp 7aa0ba72c4cc3b688ce6374b3308945ea8cb7572 


Diff: https://reviews.apache.org/r/63859/diff/6/

Changes: https://reviews.apache.org/r/63859/diff/5-6/


Testing
-------

See https://reviews.apache.org/r/63862/ for test results.


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message