mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call.
Date Fri, 12 Jan 2018 12:23:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65122/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Greg Mann, and Kevin Klues.


Bugs: MESOS-7742
    https://issues.apache.org/jira/browse/MESOS-7742


Repository: mesos


Description
-------

Previously, io switchboard terminated itself after io redirect is
finished and before http response was sent to the agent for
`ATTACH_CONTAINER_INPUT` request. This patch adds a check that an
input connection exists in io redirect completion callback to postpone
termination until `ATTACH_CONTAINER_INPUT` is completely processed.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 89dd4988c7132d3c7aeacecad7a76961b0ec5a2c



Diff: https://reviews.apache.org/r/65122/diff/1/


Testing
-------

sudo make check (Fedora 25)
internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message