mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID.
Date Fri, 12 Jan 2018 10:57:58 GMT


> On Jan. 11, 2018, 10:22 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 10343-10344 (patched)
> > <https://reviews.apache.org/r/65096/diff/1/?file=1939031#file1939031line10343>
> >
> >     What about speculative operations initiated via the operator API on resources
offered by resource-provider-capable agents? I think we would hit this CHECK in that case?

Good catch.

I now preventing outputing a default `framework_id` value in the logging and moved the `CHECK`
below the early exit for speculated operations.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/#review195253
-----------------------------------------------------------


On Jan. 12, 2018, 11:53 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65096/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 11:53 a.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-8422
>     https://issues.apache.org/jira/browse/MESOS-8422
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes logging of master's `updateOperation` for operations
> without framework ID. We also add a `CHECK` before the part updating
> resources or the allocator for non-speculated operations; currently
> non-speculated operations can only be initiated from a framework, but
> not from e.g., the operation API, and additional work is needed to
> support this.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab 
> 
> 
> Diff: https://reviews.apache.org/r/65096/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message