mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65072: Fixed handling of terminal operations in `updateSlave` handler.
Date Fri, 12 Jan 2018 10:57:53 GMT


> On Jan. 11, 2018, 3:07 a.m., Gaston Kleiman wrote:
> > src/master/master.cpp
> > Line 10419 (original), 10447 (patched)
> > <https://reviews.apache.org/r/65072/diff/1/?file=1938265#file1938265line10459>
> >
> >     Shouldn't we skip this if the operation was already in a terminal state?

Why would we call `updateOperation` if we wanted no update? I'd prefer to keep updating here
if asked since I cannot see how it would do harm.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65072/#review195202
-----------------------------------------------------------


On Jan. 12, 2018, 11:57 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65072/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 11:57 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Bugs: MESOS-8422
>     https://issues.apache.org/jira/browse/MESOS-8422
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> An offer operation can be become terminal between any previously
> received non-terminal offer operation status update and receiving an
> `UpdateSlaveMessage` (e.g., if the agent failed over, or when the
> agent was partitioned from the master).
> 
> The master will in its offer operations status handler attempt
> to apply operations which became terminal since the last update. At
> the same time, the total resources in an `UpdateSlaveMessage` would
> already contain the result of applying the operation, and we need to
> prevent the master from attempting to apply the same operation twice.
> 
> This patch updates the master handler for `UpdateSlaveMessage` to
> transition pending operations which are reported as terminal without
> also updating the resources on the agent as any update would already
> be reflected in the new total from the `UpdateSlaveMessage.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab 
> 
> 
> Diff: https://reviews.apache.org/r/65072/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message