mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID.
Date Fri, 12 Jan 2018 10:53:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/
-----------------------------------------------------------

(Updated Jan. 12, 2018, 11:53 a.m.)


Review request for mesos and Jan Schlicht.


Changes
-------

Addressed issue identified by Greg.


Summary (updated)
-----------------

Fixed master's `updateOperation` for operations without framework ID.


Bugs: MESOS-8422
    https://issues.apache.org/jira/browse/MESOS-8422


Repository: mesos


Description (updated)
-------

This patch fixes logging of master's `updateOperation` for operations
without framework ID. We also add a `CHECK` before the part updating
resources or the allocator for non-speculated operations; currently
non-speculated operations can only be initiated from a framework, but
not from e.g., the operation API, and additional work is needed to
support this.


Diffs (updated)
-----

  src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab 


Diff: https://reviews.apache.org/r/65096/diff/2/

Changes: https://reviews.apache.org/r/65096/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message