mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 63939: Added a script to build Mesos docker image.
Date Fri, 12 Jan 2018 00:49:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63939/#review195275
-----------------------------------------------------------


Ship it!




LGTM!

- Gilbert Song


On Nov. 18, 2017, 10:28 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63939/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2017, 10:28 p.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This script leverages the packaging scripts to build the RPM first, and
> then generate the Mesos docker image by installing the Mesos RPM. This
> results in smaller Mesos docker image.
> 
> This script can be run on both Linux or OSX. You just need to have
> Docker installed.
> 
> Currently, the script will build a Mesos docker image from the current
> head. Future work will make it work for building a specific tag or sha.
> 
> 
> Diffs
> -----
> 
>   support/packaging/centos/build-docker-image.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63939/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on CentOS7 and OSX
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message