mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64993: Made the `os::read` error less redundant.
Date Thu, 11 Jan 2018 21:54:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64993/#review195256
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Jan. 11, 2018, 1:53 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64993/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2018, 1:53 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Gilbert Song.
> 
> 
> Bugs: MESOS-8404
>     https://issues.apache.org/jira/browse/MESOS-8404
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The error from `os::read` would typically format as "Failed to open
> file: File not found", which is unnecessarily redundant. It should
> be sufficient to just report the `ErrnoError()`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/read.hpp 2eb74216792ee1ac902f234076a4508d40483598 
> 
> 
> Diff: https://reviews.apache.org/r/64993/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message