mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65096: Added a `CHECK` to master's `updateOperation`.
Date Thu, 11 Jan 2018 21:22:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/#review195253
-----------------------------------------------------------




src/master/master.cpp
Lines 10343-10344 (patched)
<https://reviews.apache.org/r/65096/#comment274425>

    What about speculative operations initiated via the operator API on resources offered
by resource-provider-capable agents? I think we would hit this CHECK in that case?


- Greg Mann


On Jan. 11, 2018, 1:53 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65096/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2018, 1:53 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-8422
>     https://issues.apache.org/jira/browse/MESOS-8422
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, only operations with framework ID are supported. Code in
> master's `updateSlave` was inconsistently in this regard, with it both
> implicitly asserting that any operation had a framework ID and also
> checking it presence explicitly.
> 
> This patch simplifies the existing code and adds an explicit assertion
> for the presence of a framework ID in any operation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 7ed15e4ba2a31c5fe4b8571f645cdca69a3e82f4 
> 
> 
> Diff: https://reviews.apache.org/r/65096/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message