mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 65048: Logged socket create/connect failures on warning level.
Date Thu, 11 Jan 2018 11:59:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65048/
-----------------------------------------------------------

(Updated Jan. 11, 2018, 11:59 a.m.)


Review request for mesos, Andrei Budnik and Benjamin Mahler.


Repository: mesos


Description
-------

If a socket create or connect failure occurs during link() or send(),
the reason for error is not propagated to the library user. Also, the
data being sent or queued is silently dropped on the floor. The socket
code does not log itself on a higher level when an error situation
occurs. The only trace is the log entries touched in this patch:
having them at warning level will significantly simplify debugging.

This patch also consistently logs send / link target.


Diffs (updated)
-----

  3rdparty/libprocess/src/process.cpp 53969a79f5e877b955dcab5c3ab9e508ebe96e88 


Diff: https://reviews.apache.org/r/65048/diff/2/

Changes: https://reviews.apache.org/r/65048/diff/1-2/


Testing
-------

`make check` on Mac OS 10.11.6


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message