mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 65071: Fixed composing containerizer hanging in `wait()` after recovery.
Date Thu, 11 Jan 2018 11:03:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65071/#review195218
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Jan. 10, 2018, 6:48 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65071/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 6:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-8391
>     https://issues.apache.org/jira/browse/MESOS-8391
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes the issue when `wait()` of composing containerizer
> returns a future that is never set to `READY` state due to a missing
> `wait()` call on corresponding containerizer after it's recovery.
> It is necessary to call `wait()` for each known container of composing
> containerizer, because any terminated container should be handled in
> `_destroy()` callback that is bound to that `wait()`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.cpp 9ace70d9fbd78182715c5ef13fcaf7ad45f76f97 
> 
> 
> Diff: https://reviews.apache.org/r/65071/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check (fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message