mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 63861: Windows: Updated networking doc.
Date Wed, 10 Jan 2018 22:28:37 GMT


> On Jan. 10, 2018, 12:32 p.m., Alexander Rukletsov wrote:
> > docs/networking.md
> > Lines 118-122 (patched)
> > <https://reviews.apache.org/r/63861/diff/8/?file=1938000#file1938000line118>
> >
> >     Can you please mention that other network modes than `NAT` and `USER` are not
supported in Mesos?

Could you elaborate what you mean by this? I already said that `HOST` is unsupported on Windows,
but `BRIDGE` (interpretted as `NAT`), `NONE` and `USER` work on Windows.


> On Jan. 10, 2018, 12:32 p.m., Alexander Rukletsov wrote:
> > docs/networking.md
> > Line 118 (original), 121-123 (patched)
> > <https://reviews.apache.org/r/63861/diff/8/?file=1938000#file1938000line121>
> >
> >     I'm not sure this is true with our proto having a default value. Can you please
verify that?

In the docker and health check tests, the tests work even if I don't specify `containerInfo.mutable_docker()->set_network()`.
If the default was being set to `HOST` on Windows, then it should have errored out. So, it
looks like the right default (`NAT/BRIDGE`) is being picked up on the receiver side. However,
I'm not sure how marathon or other frameworks encode the default protobuf value.


- Akash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review195131
-----------------------------------------------------------


On Jan. 10, 2018, 1:42 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 1:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
Jie Yu, John Kordich, and Michael Park.
> 
> 
> Bugs: MESOS-7342
>     https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -----
> 
>   docs/networking.md bdd3a762435aae163fc659cc0000fea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message