mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 63422: Added os::eraseenv to clear the old environment value.
Date Wed, 10 Jan 2018 22:00:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63422/
-----------------------------------------------------------

(Updated Jan. 10, 2018, 10 p.m.)


Review request for mesos and Greg Mann.


Bugs: MESOS-8140
    https://issues.apache.org/jira/browse/MESOS-8140


Repository: mesos


Description
-------

On Linux, updating the environment with unsetenv(3) does
not change the value that other processes can inspect
(e.g. through `/proc/$pid/environ`). We have to overwrite
the existing value (if any) prior to calling unsetenv(3)
if we want to ensure that the value is really gone.


Diffs (updated)
-----

  3rdparty/stout/include/stout/posix/os.hpp 7427bd792368fbacafb23593dfb9213618fdcddf 
  3rdparty/stout/tests/os/env_tests.cpp 0e94b386569b6265c5027cbda82a24daa4efb90b 


Diff: https://reviews.apache.org/r/63422/diff/4/

Changes: https://reviews.apache.org/r/63422/diff/3-4/


Testing
-------

make check (Fedora 26)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message