mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65074: Fixed comparison logic for additive reconfiguration policy.
Date Wed, 10 Jan 2018 18:01:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65074/#review195153
-----------------------------------------------------------



FAIL: mesos-java failed to build.

Reviews applied: `['65074']`

Failed command: `cmake.exe --build . --target mesos-java`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65074

Relevant logs:

- [mesos-java-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65074/logs/mesos-java-build-cmake-stdout.log):

```
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xlocale(1578):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_4d2c3142ex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\util\type_resolver_util.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google/protobuf/type.pb.h(196):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_47446fc4ex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\util\internal\protostream_objectwriter.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xlocale(2033):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_d2dd1a1asy':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\util\time_util.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google/protobuf/arenastring.h(190):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_5c8afaafex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\util\json_util.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xtree(1995):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_b61d399esy':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\util\internal\proto_writer.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google/protobuf/descriptor.pb.h(2436):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_98fbf639ex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\util\internal\type_info.cc(180):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_20630ac8gl':
No space left on device [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\util\message_differencer.cc(1757):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_f9428994gl':
No space left on device [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xstring(3626):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_bd105d09ex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\io\zero_copy_stream.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\type_traits(1554):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_b381b4b5sy':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\arena.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\string(517):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_bfd326f6ex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\arenastring.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xstring(2433):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_3f5989bcex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\io\coded_stream.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\type_traits(1539):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_1a3e7ba7ex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\generated_message_table_driven_lite.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xstring(1782):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_86f1c13cex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\extension_set.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xlocale(2353):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_c43a18e5sy':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\stubs\atomicops_internals_x86_msvc.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xiosbase(264):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_157c83ebex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\message_lite.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(276):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_c40bff2cex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\stubs\bytestream.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xiosbase(298):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_beca9d0dex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\stubs\stringpiece.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\stubs\status.cc(135):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_938d7043gl':
No space left on device [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\stubs\int128.cc(202):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_272284fagl':
No space left on device [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\stubs\statusor.cc(47):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_04f2cedbex':
No space left on device [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\iosfwd(298):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_809ff983ex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\stubs\once.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xstring(3594):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_2fdd6cecex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\stubs\stringprintf.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(311):
fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_ac35c911ex':
No space left on device (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\stubs\io_win32.cc)
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf-lite.vcxproj]
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]

    191 Warning(s)
    168 Error(s)

Time Elapsed 00:10:59.27
```

- [mesos-java-build-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65074/logs/mesos-java-build-CMakeOutput.log):

```
  Creating directory "cmTC_a2be5.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_a2be5.dir\Debug\cmTC_a2be5.tlog\".

InitializeBuildStatus:

  Creating "cmTC_a2be5.dir\Debug\cmTC_a2be5.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_a2be5.dir\Debug\" /Fd"cmTC_a2be5.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_a2be5.dir\Debug\" /Fd"cmTC_a2be5.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_a2be5.exe" /INCREMENTAL
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib
uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'"
/manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_a2be5.pdb" /SUBSYSTEM:CONSOLE
/TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_a2be5.lib"
/MACHINE:X64  /machine:x64 cmTC_a2be5.dir\Debug\src.obj

  cmTC_a2be5.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_a2be5.exe

FinalizeBuildStatus:

  Deleting file "cmTC_a2be5.dir\Debug\cmTC_a2be5.tlog\unsuccessfulbuild".

  Touching "cmTC_a2be5.dir\Debug\cmTC_a2be5.tlog\cmTC_a2be5.lastbuildstate".

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_a2be5.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:01.19


Source file was:
int main() { return 0; }
```

- [mesos-java-build-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65074/logs/mesos-java-build-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_4919b.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_4919b.dir\Debug\cmTC_4919b.tlog\".

InitializeBuildStatus:

  Creating "cmTC_4919b.dir\Debug\cmTC_4919b.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_4919b.dir\Debug\" /Fd"cmTC_4919b.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D
_UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_4919b.dir\Debug\" /Fd"cmTC_4919b.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_4919b.vcxproj]

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_4919b.vcxproj" (default targets)
-- FAILED.



Build FAILED.



"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_4919b.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open
include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_4919b.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:00.58



```

- Mesos Reviewbot Windows


On Jan. 10, 2018, 4:07 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65074/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 4:07 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8410
>     https://issues.apache.org/jira/browse/MESOS-8410
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The case where multiple resources have the same name
> was not handled correctly, and could result in false
> negatives.
> 
> To fix this, we now consider all resource metadata in addition to the name when searching
for a matching resource in the previous configuration.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 69bf823f800ac8bfc2bc211895b0967f573009b5 
>   src/common/resources.cpp 1291208b9f2a7c373ff7ec941d3e4310fec92207 
>   src/slave/compatibility.hpp 78b421a01abe5d2178c93832577577a7ba282b38 
>   src/slave/compatibility.cpp 4ead4a5b655f6f3d7812aa52d656830d7cff4598 
>   src/tests/slave_compatibility_tests.cpp ab5ed29f43c593dbd7d90c235aa304b581d932a2 
> 
> 
> Diff: https://reviews.apache.org/r/65074/diff/1/
> 
> 
> Testing
> -------
> 
> * Several new unit tests added in the review
> * `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message