mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 65073: Fixed post-reviews for posting reviews from `master` branch.
Date Wed, 10 Jan 2018 15:40:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65073/#review195139
-----------------------------------------------------------




support/post-reviews.py
Lines 189 (patched)
<https://reviews.apache.org/r/65073/#comment274286>

    s/`"from {}!"`/`" from {}!"`.


- Armand Grillet


On Jan. 10, 2018, 3:28 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65073/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 3:28 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The post-reviews script allows to specify the tracking branch against
> which to post reviews; we default to creating patches against
> `master`.
> 
> The script also contains some protection against posting reviews from
> the tracking branch, but this protection seems to predate the tracking
> branch configuration flag. Instead we also disallow posting patches
> from the `master` branch, even if the tracking branch is not `master`.
> 
> This patch fixes this sanity check to check that the current and
> tracking branch are different.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 7e3f0f48f7e9019b68c074eb85c17255a3b4390e 
> 
> 
> Diff: https://reviews.apache.org/r/65073/diff/1/
> 
> 
> Testing
> -------
> 
> Successfully posted this patch from `master` against `origin/master`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message