mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 65072: Fixed handling of terminal operations in updateSlave handler.
Date Wed, 10 Jan 2018 15:17:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65072/
-----------------------------------------------------------

Review request for mesos, Gaston Kleiman and Greg Mann.


Repository: mesos


Description
-------

An offer operation can be become terminal between any previously
received non-terminal offer operation status update and receiving an
`UpdateSlaveMessage` (e.g., if the agent failed over, or when the
agent was partitioned from the master).

The master will in its offer operations status handler attempt
to apply operations which became terminal since the last update. At
the same time, the total resources in an `UpdateSlaveMessage` would
already contain the result of applying the operation, and we need to
prevent the master from attempting to apply the same operation twice.

This patch updates the master handler for `UpdateSlaveMessage` to
transition pending operations which are reported as terminal. For that
we add a new parameter to `updateOperation` to selectively disable
updating of resource state as needed in when called from the
`UpdateSlaveMessage` handler.


Diffs
-----

  src/master/master.hpp 5e6ba53c075174a1e514a395ceb17c26201ec470 
  src/master/master.cpp 6fc5de89e54ba0b9ae2c4fb475be9878910820d3 


Diff: https://reviews.apache.org/r/65072/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message