mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64386: Windows: Enabled docker health checks.
Date Wed, 10 Jan 2018 13:16:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64386/#review195132
-----------------------------------------------------------




src/checks/checker.hpp
Lines 73 (patched)
<https://reviews.apache.org/r/64386/#comment274276>

    I think all such commands should not be passed from outside, but be part of the library
itself. The library shall be capable of determining the target platform and use an appropriate
command.



src/checks/checker_process.cpp
Lines 1009-1013 (original), 1016-1025 (patched)
<https://reviews.apache.org/r/64386/#comment274277>

    This means mesos-tcp-connect is not used for tcp checks with docker executor? Why? Is
the solution your propose more efficient?



src/docker/executor.cpp
Lines 665-675 (patched)
<https://reviews.apache.org/r/64386/#comment274275>

    Why is this not part of the health check library? This way, the code related to http and
tcp checking is scattered over the codebase.


- Alexander Rukletsov


On Jan. 10, 2018, 1:28 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64386/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 1:28 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
Jie Yu, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The network health checks called curl and then executed setns to
> enter to container network namespace, which did not work on Windows.
> To do the equivalent, Windows nows calls docker run with powershell's
> curl equivalent (Invoke-WebRequest) and uses the
> network=container:<ID> flag to enter the container's namespace.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.hpp 93502270f31e80c5f7c94b5b456625e9cdea1837 
>   src/checks/checker.cpp fff0aac504b4283a210f936e00c977fa60d88b3d 
>   src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 
>   src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f 
>   src/checks/health_checker.hpp 019fbd791f250ecc28ff59d779f90e7ccbf0c685 
>   src/checks/health_checker.cpp eaf9a18817eeeff7c29c7a4b9d1b183f398760a3 
>   src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 
>   src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a 
>   src/launcher/executor.cpp 794bf7ca07e68c7d83993546c134f85cac5a68e3 
> 
> 
> Diff: https://reviews.apache.org/r/64386/diff/5/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/64387/
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message