mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64906: Exposed `send()` helpers for `Socket`'s.
Date Wed, 10 Jan 2018 04:10:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64906/#review195117
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/http.cpp
Lines 1876-1883 (patched)
<https://reviews.apache.org/r/64906/#comment274257>

    Do you know why these send calls need to copy the response?


- Benjamin Mahler


On Jan. 3, 2018, 7:19 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64906/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2018, 7:19 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pulled out two `send()` functions that simplify sending an
> `http::Response` and an `Encoder` using a `Socket`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 055447e13117c0a3ba79d0fc326ece657e8f064f

>   3rdparty/libprocess/src/encoder.hpp 70b5ec479e90c0eb6ac729b465739b581729a956 
>   3rdparty/libprocess/src/http.cpp f51d2aaa639ee36ce960268cb32a3aa88f14aa29 
> 
> 
> Diff: https://reviews.apache.org/r/64906/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message