mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65054: Fixed the order of parameters of `is_specialization_of` in stout.
Date Wed, 10 Jan 2018 01:50:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65054/#review195109
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Jan. 9, 2018, 11:56 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65054/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2018, 11:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Given `std::is_base_of<T, U>`, the interpretation of the question is:
> "is `T` base of `U`?". Similarly, in this case want to ask the question
> "is some type a specialization of a template?" As such, the order of
> template paramters should be `is_specialization_of<Type, Template>`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/traits.hpp 5dea08404fd12f68af0538a16c5ee1d9734dd8c5 
> 
> 
> Diff: https://reviews.apache.org/r/65054/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message