mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65031: Replaced `convertResourceFormat` with `downgradeResources` accordingly.
Date Wed, 10 Jan 2018 01:47:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65031/#review195107
-----------------------------------------------------------


Ship it!





src/master/registry_operations.cpp
Line 189 (original), 185 (patched)
<https://reviews.apache.org/r/65031/#comment274254>

    Should we be checking these?


- Benjamin Mahler


On Jan. 8, 2018, 8:36 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65031/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2018, 8:36 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8375
>     https://issues.apache.org/jira/browse/MESOS-8375
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced `convertResourceFormat` with `downgradeResources` accordingly.
> 
> 
> Diffs
> -----
> 
>   src/master/registry_operations.hpp 41047f0b672ebbfe8d323221f37bf6b617e8b6ea 
>   src/master/registry_operations.cpp 149009b07663f530c444d0b66667205f23fe4510 
> 
> 
> Diff: https://reviews.apache.org/r/65031/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message