mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65030: Replaced `convertResourceFormat` with `upgradeResources` accordingly.
Date Wed, 10 Jan 2018 01:43:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65030/#review195106
-----------------------------------------------------------


Ship it!




Can you run the failover benchmark before and after this change? I'm curious if reflecting
on the entire slave re-registration message has a significant cost. Or is it the case that
we cached the descriptor state and only the first call has to fully reflect?


src/slave/slave.cpp
Lines 1686-1692 (original), 1686-1692 (patched)
<https://reviews.apache.org/r/65030/#comment274253>

    Hm.. ideally we could have runTask() and runTaskGroup() take the Message&& and
do the conversion there, instead of on the arguments to run().
    
    Up to you, probably should do this in a separate review.


- Benjamin Mahler


On Jan. 8, 2018, 8:27 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65030/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2018, 8:27 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8375
>     https://issues.apache.org/jira/browse/MESOS-8375
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced `convertResourceFormat` with `upgradeResources` accordingly.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 1291208b9f2a7c373ff7ec941d3e4310fec92207 
>   src/master/master.cpp 28d8be3a4769b418b61cff0b95845e4232135bc7 
>   src/master/quota_handler.cpp b1757e7a1f64b0843c1213324c4d12986563a002 
>   src/master/registry_operations.cpp 149009b07663f530c444d0b66667205f23fe4510 
>   src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850 
>   src/slave/validation.cpp 7444d6a5a78e8d7abd739b5ab564f3e1eca35c8b 
>   src/tests/master_quota_tests.cpp 79c0739a60d6f1b5d104313856841751a924f0c0 
>   src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e 
>   src/tests/persistent_volume_tests.cpp 22ae2104b101cf70751b67774803aefce555b7e7 
>   src/tests/reservation_tests.cpp c19d9442dd93c81be8dea1ea00b1cf723174068e 
> 
> 
> Diff: https://reviews.apache.org/r/65030/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message