mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 64570: Windows: Temporarily fixed the docker executor.
Date Wed, 10 Jan 2018 01:26:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64570/
-----------------------------------------------------------

(Updated Jan. 10, 2018, 1:26 a.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu,
and Michael Park.


Changes
-------

rebased and fixed #ifdef comment.


Repository: mesos


Description
-------

The docker executor was setting its `PATH` through
`os::host_default_path()`, so it could not find the docker executable.
Now, on Windows, the docker executor inherits the environment variables
from the agent. Further investigation needs to be done on why `PATH`
was this way and if the docker executor could simply inherit the
agent's environment.


Diffs (updated)
-----

  src/slave/containerizer/docker.cpp 890cb2aba44fe76e891117833eac8ccca00b759b 


Diff: https://reviews.apache.org/r/64570/diff/3/

Changes: https://reviews.apache.org/r/64570/diff/2-3/


Testing
-------

See https://reviews.apache.org/r/64386/


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message