mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65023: Added `state::read` to complement `state::checkpoint`.
Date Wed, 10 Jan 2018 01:19:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65023/#review195099
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/state.hpp
Lines 78 (patched)
<https://reviews.apache.org/r/65023/#comment274244>

    extra a



src/slave/state.hpp
Lines 84-86 (patched)
<https://reviews.apache.org/r/65023/#comment274245>

    Early return on error?


- Benjamin Mahler


On Jan. 8, 2018, 6:14 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65023/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2018, 6:14 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8375
>     https://issues.apache.org/jira/browse/MESOS-8375
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `state::read` to complement `state::checkpoint`.
> 
> 
> Diffs
> -----
> 
>   src/slave/state.hpp 01abb5095cf09dd36d7f154d007336892bd8df46 
> 
> 
> Diff: https://reviews.apache.org/r/65023/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message