mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 64968: Removed the inaccurate `slaves.transitioning` function in the master.
Date Wed, 10 Jan 2018 00:41:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64968/#review195094
-----------------------------------------------------------


Ship it!





src/master/master.cpp
Lines 8507 (patched)
<https://reviews.apache.org/r/64968/#comment274241>

    Perhaps it'll be more informative to log the `slaveId` if it is present? i.e., distinguish
the two sub-cases in logging?


- Jiang Yan Xu


On Jan. 4, 2018, 5:38 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64968/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2018, 5:38 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8390
>     https://issues.apache.org/jira/browse/MESOS-8390
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This function used to return whether the agent was transitioning
> between states, however it was updated in e510813f93e253480005ce
> to return only when the agent is recovered.
> 
> This patch removes the now confusing function in favor of just
> directly checking the state we care about in the reconciliation
> logic. Since there were no other usages, the function is removed.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 130f6e28cc62a8912aac66ecfbf014fe1ee444e3 
>   src/master/master.cpp 28d8be3a4769b418b61cff0b95845e4232135bc7 
> 
> 
> Diff: https://reviews.apache.org/r/64968/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message