mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64936: Improved the documentation of protos related to operation feedback.
Date Wed, 10 Jan 2018 00:18:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64936/#review195093
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 2309-2312 (patched)
<https://reviews.apache.org/r/64936/#comment274238>

    I think this is a little hard to follow. Perhaps something like:
    
    "While frameworks will only receive status updates for operations on which they have set
an ID, this field is optional because this message is also used internally by Mesos components
when the operation's ID has not been set."
    
    WDYT?



include/mesos/scheduler/scheduler.proto
Lines 408 (patched)
<https://reviews.apache.org/r/64936/#comment274239>

    s/agent_id/slave_id/



include/mesos/scheduler/scheduler.proto
Lines 410 (patched)
<https://reviews.apache.org/r/64936/#comment274240>

    Nit: s/an/a/ for consistency


- Greg Mann


On Jan. 3, 2018, 11:49 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64936/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2018, 11:49 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved the documentation of protos related to operation feedback.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto c677a8be07d0ef209d42622ae32056d36e55ff78 
>   include/mesos/scheduler/scheduler.proto 4258fb38a412a2c9d977b1b38c97cc3ab9d5090e 
>   include/mesos/v1/mesos.proto da7b4587891c47c02345209e0fdca60585a36fdc 
>   include/mesos/v1/scheduler/scheduler.proto 688ba55b11cf21bc71c15a711c2b2ac5d8655c9f

> 
> 
> Diff: https://reviews.apache.org/r/64936/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message