mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 65050: Added some defensive checks for persistent volume sharing check.
Date Tue, 09 Jan 2018 20:44:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65050/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, James Peach, and Jiang Yan Xu.


Bugs: MESOS-8356
    https://issues.apache.org/jira/browse/MESOS-8356


Repository: mesos


Description
-------

This patch adds some defensive checks for detecting if a persistent
volume is shared by multiple containers. It's currently not a bug
because of a `contains` check above in the loop body. But this is a bit
fragile and should be avoided.

See more details in MESOS-8356.


Diffs
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 5200182970fa978e940d3f0e9cddce37608e84f7

  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 6b9f4bb42621eec3eb648712fbfa41d94f253895



Diff: https://reviews.apache.org/r/65050/diff/1/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message