mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65048: Logged socket create/connect failures on warning level.
Date Tue, 09 Jan 2018 20:37:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65048/#review195069
-----------------------------------------------------------


Fix it, then Ship it!




Can you consistently log who we're trying to link / send a message to? Some of them have the
destination but some don't.


3rdparty/libprocess/src/process.cpp
Line 1413 (original), 1413 (patched)
<https://reviews.apache.org/r/65048/#comment274205>

    Can you log the destination we're trying to link to? Ditto on the other cases.


- Benjamin Mahler


On Jan. 9, 2018, 6:19 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65048/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2018, 6:19 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a socket create or connect failure occurs during link() or send(),
> it is not propagated to the library user. Also, the data being sent or
> queued is silently dropped on the floor. The socket code does not log
> itself on a higher level when an error situation occurs. The only
> trace is the log entries touched in this patch: having them at warning
> level will significantly simplify debugging.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 53969a79f5e877b955dcab5c3ab9e508ebe96e88 
> 
> 
> Diff: https://reviews.apache.org/r/65048/diff/1/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message