mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64733: Fixed conversion warnings in tests.
Date Tue, 09 Jan 2018 19:08:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64733/
-----------------------------------------------------------

(Updated Jan. 9, 2018, 11:08 a.m.)


Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Stringified a `size_t` for `http::Request.headers` value.

The types in `metrics_tests.cpp` were defined as `double`, and so should
be compared with `EXPECT_DOUBLE_EQ`, not `EXPECT_FLOAT_EQ`.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/http_tests.cpp 9daac715f0242921b7f9f5c20b3eb27f1be802d4 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 5f7117e4ee404643b4d784cd5f0308ee23f097cb



Diff: https://reviews.apache.org/r/64733/diff/3/

Changes: https://reviews.apache.org/r/64733/diff/2-3/


Testing
-------

These are in libprocess.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message