mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64730: Changed `Sorter::count()` to return `size_t` instead of `int`.
Date Tue, 09 Jan 2018 19:07:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64730/
-----------------------------------------------------------

(Updated Jan. 9, 2018, 11:07 a.m.)


Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Also applies to `DRFSorter::count()`. The implementations return
`hashmap::count()` which is a `size_t`. Converting `size_t` to `int`
implicitly generates a "possible loss of data" warning.


Diffs (updated)
-----

  src/master/allocator/sorter/drf/sorter.hpp 1a7681c69b3d28efbf3d37dfaece55743e48c101 
  src/master/allocator/sorter/drf/sorter.cpp ecc5586737b6b447c5a1cf1a37037832bcbacd69 
  src/master/allocator/sorter/sorter.hpp 2c6e1621fc8b3a01750f6fa3b15f5dcd57216cc6 


Diff: https://reviews.apache.org/r/64730/diff/2/

Changes: https://reviews.apache.org/r/64730/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message