mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 64743: Enabled function sections.
Date Tue, 09 Jan 2018 18:41:37 GMT


> On Jan. 9, 2018, 4:10 p.m., Benjamin Bannier wrote:
> > Thanks for adjusting this.
> > 
> > It would be great if you could update the ticket with e.g., benchmark results so
people get a first feel for whether it makes sense for them to enable this feature in production
builds.

Added a quick benchmark to the JIRA. No obvious perf impact on that particular benchmark.


> On Jan. 9, 2018, 4:10 p.m., Benjamin Bannier wrote:
> > configure.ac
> > Lines 175 (patched)
> > <https://reviews.apache.org/r/64743/diff/5/?file=1930931#file1930931line175>
> >
> >     I wonder whether it would make sense to use a more high-level name for this
(in the end this is about using sections which can be gc'ed, not just function sections).

Changed to `--enable-gc-unused` as per chat.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review195039
-----------------------------------------------------------


On Jan. 9, 2018, 6:40 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2018, 6:40 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8348
>     https://issues.apache.org/jira/browse/MESOS-8348
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318 
>   configure.ac b6eb98bfe5539c68a416831c36c182ee907d9421 
>   docs/configuration/autotools.md c6ac196fd5023391143313821185cac096b41a2b 
>   docs/configuration/cmake.md 5364b1e0398e8e774c89993bd7404c32abe3bedc 
> 
> 
> Diff: https://reviews.apache.org/r/64743/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message