mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 64515: Used `reserve_resources` ACL for static reservations.
Date Tue, 09 Jan 2018 16:45:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64515/#review195042
-----------------------------------------------------------



What do you think about testing the re-registration case? There's no coverage here, but equally,
it would be annoying to duplicate all these tests for re-registration ...


src/tests/master_authorization_tests.cpp
Lines 2516 (patched)
<https://reviews.apache.org/r/64515/#comment274168>

    What happens with the "*" role? Is that covered by "AuthorizedToRegisterNoStaticReservations"?



src/tests/master_authorization_tests.cpp
Lines 2538 (patched)
<https://reviews.apache.org/r/64515/#comment274169>

    "high-security-principal"



src/tests/master_authorization_tests.cpp
Lines 2575 (patched)
<https://reviews.apache.org/r/64515/#comment274170>

    "statically reserving resources for a ..."?


- James Peach


On Jan. 3, 2018, 7 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64515/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2018, 7 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and James Peach.
> 
> 
> Bugs: MESOS-8306
>     https://issues.apache.org/jira/browse/MESOS-8306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `reserve_resources` ACL for static reservations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto d869820491f1b81f81e1157493aa73e32735b9c3 
>   src/master/master.hpp 8fe9420dbe03ea2cefc6a40b0f64284aa9fe7915 
>   src/master/master.cpp 282fdf8ac38e3613c621c1c8e5c50f27bde9dafd 
>   src/tests/master_authorization_tests.cpp 676543a5ad1bb5d47011fc2a8b05dfaaeef18c64 
> 
> 
> Diff: https://reviews.apache.org/r/64515/diff/3/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message