mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 64516: Improved documentation on resource reservations.
Date Tue, 09 Jan 2018 16:27:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64516/#review195041
-----------------------------------------------------------




docs/reservation.md
Lines 80 (patched)
<https://reviews.apache.org/r/64516/#comment274164>

    "so that reources can only be resrved for patricular roles, and ..."



docs/reservation.md
Lines 88 (patched)
<https://reviews.apache.org/r/64516/#comment274165>

    "Similarly, agents can register ..."



docs/reservation.md
Lines 89 (patched)
<https://reviews.apache.org/r/64516/#comment274166>

    "with resources that are statically reserved for arbitrary roles"
    
    Also, add a comma after "With authorization"



docs/reservation.md
Lines 91 (patched)
<https://reviews.apache.org/r/64516/#comment274167>

    "to check that the agent's `principal` is allowed to statically reserve resources for
specific roles"
    
    maybe clearer?


- James Peach


On Dec. 12, 2017, 12:34 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64516/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 12:34 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, James Peach, and Michael Park.
> 
> 
> Bugs: MESOS-8306
>     https://issues.apache.org/jira/browse/MESOS-8306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added explanation for authorizations on static reservations.
> 
> 
> Diffs
> -----
> 
>   docs/reservation.md fa1f309f2b770e37964af2d5599519875195dbec 
> 
> 
> Diff: https://reviews.apache.org/r/64516/diff/1/
> 
> 
> Testing
> -------
> 
> Used a markdown viewer.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message