mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64930: Unified the marking agent unreachable logic in the master.
Date Tue, 09 Jan 2018 08:06:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64930/
-----------------------------------------------------------

(Updated Jan. 9, 2018, 8:06 a.m.)


Review request for mesos, Benno Evers and Vinod Kone.


Changes
-------

Updates from benno's review.


Repository: mesos


Description
-------

The logic for marking an agent unreachable in the master had two
very similar code paths that differed slightly across failover
and steady state cases. This patch uses a single code path.

Unfortunately, some slight differences were necessary, and a
failover boolean was introduced to accomodate them. Specifically,
the failover and steady state cases expect the agent to reside
in the recovered and registered lists, respectively.


Diffs (updated)
-----

  src/master/master.hpp 130f6e28cc62a8912aac66ecfbf014fe1ee444e3 
  src/master/master.cpp 1610f4331225235e85f5a83e5338870cef99a5c8 
  src/tests/slave_tests.cpp 159192053087e971746943a1bc17a76143a2d9af 


Diff: https://reviews.apache.org/r/64930/diff/2/

Changes: https://reviews.apache.org/r/64930/diff/1-2/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message