mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 63861: Windows: Updated networking doc.
Date Mon, 08 Jan 2018 22:27:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review194989
-----------------------------------------------------------


Fix it, then Ship it!





docs/networking.md
Lines 118 (patched)
<https://reviews.apache.org/r/63861/#comment274080>

    Nit: s/the `HOST` network/the `HOST` network mode/



docs/networking.md
Lines 121 (patched)
<https://reviews.apache.org/r/63861/#comment274081>

    s/If the network is not specified/If the network mode is not specified/
    s/the default the default network/the default mode/


- Gaston Kleiman


On Jan. 5, 2018, 10:32 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 10:32 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
Jie Yu, John Kordich, and Michael Park.
> 
> 
> Bugs: MESOS-7342
>     https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -----
> 
>   docs/networking.md bdd3a762435aae163fc659cc0000fea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/7/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message