mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 65011: Reverted back to alphabetical ordering of libprocess metrics in JSON.
Date Mon, 08 Jan 2018 16:28:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65011/#review194959
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On Jan. 8, 2018, 12:57 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65011/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2018, 12:57 a.m.)
> 
> 
> Review request for mesos, James Peach and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> At some point, the alphabetical ordering of metrics in the JSON
> response was lost. This doesn't matter for consumption within a
> program, but this loses readability for human users hitting the
> metrics via a browser or curl.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 9c32a88d851c884a5025edb6ea1e27939b484546

>   3rdparty/libprocess/src/metrics/metrics.cpp 7184aa4d0294c20466646c9aa61d90973eca22e1

> 
> 
> Diff: https://reviews.apache.org/r/65011/diff/1/
> 
> 
> Testing
> -------
> 
> Added a test in the subsequent patch.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message