mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.
Date Sun, 07 Jan 2018 10:00:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64978/
-----------------------------------------------------------

(Updated Jan. 7, 2018, 6 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

Only do the file attach/detach when it is the default executor.


Summary (updated)
-----------------

Made task's volume directory visible in the /files endpoints.


Bugs: MESOS-8279
    https://issues.apache.org/jira/browse/MESOS-8279


Repository: mesos


Description (updated)
-------

In MESOS-7225, we made a task can access any volumes specified in its
disk resources from its own sandbox by introducing a workaround to the
default executor, i.e., add a `SANDBOX_PATH` volume with type `PARENT`
to the corresponding nested container. It will be translated into a bind
mount in the nested container's mount namespace, thus not visible in the
host mount namespace, that means the task's volume directory can not be
visible in Mesos UI since it operates in the host mount namespace.

In this patch, to make the task's volume directory visible in Mesos UI,
we attached the executor's volume directory to it, so when users browse
task's volume directory in Mesos UI, what they actually browse is the
executor's volume directory. Note when calling `Files::attach()`, the
third argument `authorized` is not specified, that is because it is
already specified when we do the attach for the executor's sandbox and
it is also applied to the executor's tasks.


Diffs (updated)
-----

  src/slave/slave.cpp cfb675df677e7a0d476b8d5a586afc2f197ab810 


Diff: https://reviews.apache.org/r/64978/diff/2/

Changes: https://reviews.apache.org/r/64978/diff/1-2/


Testing (updated)
-------

sudo make check


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message